[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic |
Date: |
Thu, 19 Dec 2013 15:20:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 18/12/2013 19:03, Andreas Färber ha scritto:
>> > @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev,
>> > Error **errp)
>> > {
>> > IOAPICCommonState *s = IOAPIC_COMMON(dev);
>> > IOAPICCommonClass *info;
>> > - static int ioapic_no;
>> >
>> > if (ioapic_no >= MAX_IOAPICS) {
>> > error_setg(errp, "Only %d ioapics allowed", MAX_IOAPICS);
> ... while the check for max. IOAPICs still happens in common code.
>
> Do we need to count KVM IOAPICs as well? Or can we consolidate this into
> the non-KVM version and keep it static there?
KVM only supports one IOAPIC. Creating a second fails with EEXIST.
Paolo