[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset |
Date: |
Thu, 19 Dec 2013 21:15:48 +0200 |
On Fri, Dec 06, 2013 at 05:54:23PM +0100, Paolo Bonzini wrote:
> PCI is handling resetting of its devices before the bus is reset,
> but this is only necessary because qdev is broken and usually does
> pre-order reset. Post-order is a much better definition. Drop
> the unnecessary flexibility that lets bus decide the reset order,
> convert to post-order, and make PCI use common code for reset.
>
> Paolo Bonzini (4):
> pci: do not export pci_bus_reset
> pci: clean up resetting of IRQs
> qdev: allow both pre- and post-order vists in qdev walking functions
> qdev: switch reset to post-order
Applied, thanks!
I had to fix the last patch as it broke virtio ccw though.
Also, waiting for tests to start passing on master
again before I send pull request.
> hw/core/qdev.c | 47 ++++++++++++++++++++++++++++++++++-------------
> hw/pci/pci.c | 42 ++++++++++++++++++++----------------------
> hw/pci/pci_bridge.c | 2 +-
> include/hw/pci/pci.h | 1 -
> include/hw/qdev-core.h | 15 ++++++++++-----
> 5 files changed, 65 insertions(+), 42 deletions(-)
- [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs, (continued)
- [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs, Paolo Bonzini, 2013/12/06
- [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Paolo Bonzini, 2013/12/06
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Bandan Das, 2013/12/06
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Paolo Bonzini, 2013/12/09
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Bandan Das, 2013/12/09
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Paolo Bonzini, 2013/12/09
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Paolo Bonzini, 2013/12/09
- Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Bandan Das, 2013/12/09
[Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order, Paolo Bonzini, 2013/12/06
Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset,
Michael S. Tsirkin <=