[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_prealloc
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate. |
Date: |
Fri, 20 Dec 2013 11:10:30 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 19, 2013 at 10:27:37AM +0800, Hu Tao wrote:
> diff --git a/block.c b/block.c
> index 64e7d22..b901587 100644
> --- a/block.c
> +++ b/block.c
> @@ -3216,6 +3216,19 @@ bool bdrv_can_write_zeroes_with_unmap(BlockDriverState
> *bs)
> return false;
> }
>
> +int bdrv_preallocate(BlockDriverState *bs, int64_t offset, int64_t length)
> +{
> + if (bs->backing_hd) {
> + return -ENOTSUP;
> + }
Depending on the image file format it may be possible to preallocate
metadata while using a backing file. Why prevent this?
- [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full, Hu Tao, 2013/12/18
- [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode, Hu Tao, 2013/12/18
- [Qemu-devel] [RFC PATCH v3 4/6] raw-posix: Add full image preallocation option, Hu Tao, 2013/12/18
- [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate., Hu Tao, 2013/12/18
- Re: [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate.,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC PATCH v3 5/6] qcow2: implement bdrv_preallocate, Hu Tao, 2013/12/18
- [Qemu-devel] [RFC PATCH v3 3/6] block/raw-posix: implement bdrv_preallocate, Hu Tao, 2013/12/18
- [Qemu-devel] [RFC PATCH v3 6/6] qcow2: Add full image preallocation option, Hu Tao, 2013/12/18
- Re: [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full, Stefan Hajnoczi, 2013/12/20