Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm

[Peter Maydell]

On 20 December 2013 16:57, Richard Henderson <address@hidden> wrote:
> On 12/20/2013 08:52 AM, Peter Maydell wrote:
>> Were you planning to review patches 12 ("Remove
>> ARMCPU/CPUARMState from cpregs APIs used by decoder")
>> and 19 ("Widen exclusive-access support struct fields
>> to 64 bits") ? I think those are the only two patches in
>> this set which I don't either have review comments to fix
>> or a reviewed-by from you now.
>
> I skipped over those because they're pure target-arm internals, and not really
> translator related.  But I could have a look later today if you like.

The 'widen exclusive access fields' one could use some eyeballs
to check I didn't mess up when I reworked the generated code from
looking at two 32 bit fields to one 64 bit field. You're right that the
other one is mostly target-arm internals though.

Mostly I just wanted to know if I should be waiting for more
review before sending out a respin :-)

thanks
-- PMM