[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 04/24] qapi: extend qdict_flatten() for QList
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 04/24] qapi: extend qdict_flatten() for QLists |
Date: |
Fri, 20 Dec 2013 13:00:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 12/20/2013 11:28 AM, Max Reitz wrote:
> Reversing qdict_array_split(), qdict_flatten() should flatten QLists as
> well by interpreting them as QDicts where every entry's key is its
> index.
>
> This allows bringing QDicts with QLists from QMP commands to the same
> form as they would be given as command-line options, thereby allowing
> them to be parsed the same way.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qobject/qdict.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 48 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v7 00/24] blkdebug/blkverify: Allow QMP configuration, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 01/24] blkdebug: Use errp for read_config(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 02/24] blkdebug: Don't require sophisticated filename, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 03/24] qdict: Add qdict_array_split(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 04/24] qapi: extend qdict_flatten() for QLists, Max Reitz, 2013/12/20
- Re: [Qemu-devel] [PATCH v7 04/24] qapi: extend qdict_flatten() for QLists,
Eric Blake <=
- [Qemu-devel] [PATCH v7 05/24] qemu-option: Add qemu_config_parse_qdict(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 06/24] blkdebug: Always call read_config(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 07/24] blkdebug: Use command-line in read_config(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 08/24] block: Allow reference for bdrv_file_open(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 09/24] block: Pass reference to bdrv_file_open(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 10/24] block: Allow block devices without files, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 11/24] block: Add bdrv_open_image(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 12/24] block: Use bdrv_open_image() in bdrv_open(), Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 13/24] block: Allow recursive "file"s, Max Reitz, 2013/12/20
- [Qemu-devel] [PATCH v7 15/24] blkdebug: Allow command-line file configuration, Max Reitz, 2013/12/20