Re: [Qemu-devel] [PATCH v2 09/10] hw/mips: malta: Add KVM support

[Peter Maydell]

On 16 December 2013 14:12, James Hogan <address@hidden> wrote:
> In KVM mode the bootrom is loaded and executed from the last 1MB of
> DRAM.
>
> Based on "[PATCH 12/12] KVM/MIPS: General KVM support and support for
> SMP Guests" by Sanjay Lal <address@hidden>.
>
> Signed-off-by: James Hogan <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> ---
> Changes in v2:
>  - Removal of cps / GIC / SMP support
>  - Minimal bootloader modified to execute safely from RAM
>  - Remove "Writing bootloader to final 1MB of RAM" printf
> ---
>  hw/mips/mips_malta.c | 85 
> ++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 63 insertions(+), 22 deletions(-)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 05c8771..3fff07c 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -51,6 +51,10 @@
>  #include "sysemu/qtest.h"
>  #include "qemu/error-report.h"
>  #include "hw/empty_slot.h"
> +#include "qemu/bitmap.h"
> +#include "sysemu/kvm.h"
> +#include "linux/kvm.h"

You can't include linux/kvm.h like this -- on Linux this will pull in
whatever the host's system kvm.h happens to be, and on non-Linux
it won't compile:

/Users/pm215/src/qemu/hw/mips/mips_malta.c:56:10: fatal error:
'linux/kvm.h' file not found
#include "linux/kvm.h"
         ^
1 error generated.


thanks
-- PMM