Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

[Peter Maydell]

On 23 December 2013 13:32, Stefan Weil <address@hidden> wrote:
> Am 23.12.2013 13:59, schrieb Peter Maydell:
>> On 23 December 2013 12:50, Paolo Bonzini <address@hidden> wrote:
>>> Il 23/12/2013 13:37, Peter Maydell ha scritto:
>>>> At a minimum, if we take this approach we should add TODO comments
>>>> to the effect that the NULL terminator and the if() can be removed
>>>> when the first real AArch64 CPU is added.
>>>>
>>>> I think I'd rather put the if (!info->name) continue into the function
>>>> which is doing the looping over the array.
>>> Or just change the termination condition from a check on the array size
>>> to one on info->name.
>> That would take it out of line with the equivalent 32 bit ARM code
>> (and also moxie and openrisc for what little that's worth) and be
>> fractionally more tedious to revert later.

> What about adding a dummy CPU (which can be removed later)?

That would be user-visible, which seems a bad thing.
I agree that there aren't any fantastic solutions here;
I think something more or less like Michael's patch with
a TODO note so it's easy for me to take it out again when
I add an actual A57 emulation in a couple of months will
do. This is just a temporary thing since at the moment we
only support -cpu any for userspace and -cpu host for KVM.

thanks
-- PMM