Re: [Qemu-devel] [PATCH v2 11/25] target-arm: Pull "add one cpreg to hashtable" into its own function

[Richard Henderson]

On 12/22/2013 02:49 PM, Peter Maydell wrote:
> define_one_arm_cp_reg_with_opaque() has a set of nested loops which
> insert a cpreg entry into the hashtable for each of the possible
> opc/crn/crm values allowed by wildcard specifications. We're about
> to add an extra loop to this nesting, so pull the core of the loop
> (which adds a single entry to the hashtable) out into its own
> function for clarity.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target-arm/helper.c | 94 
> +++++++++++++++++++++++++++++------------------------
>  1 file changed, 52 insertions(+), 42 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~