Re: [Qemu-devel] [PATCH v2 1/9] target-sh4: use bit number for SR constants

[Richard Henderson]

On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
> Use the bit number for SR constants instead of using a bit mask. This
> make possible to also use the constants for shifts.
> 
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  target-sh4/cpu.c       |    3 +-
>  target-sh4/cpu.h       |   30 +++++++++----------
>  target-sh4/gdbstub.c   |    4 +--
>  target-sh4/helper.c    |   27 ++++++++---------
>  target-sh4/op_helper.c |   26 ++++++++---------
>  target-sh4/translate.c |   75 
> +++++++++++++++++++++++++-----------------------
>  6 files changed, 85 insertions(+), 80 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~