qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/9] target-sh4: optimize addc using add2


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 3/9] target-sh4: optimize addc using add2
Date: Tue, 24 Dec 2013 06:18:29 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
> +            t2 = tcg_temp_new();
> +            tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0);
> +            tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, t0);

FWIW, one can avoid an extra temporary by consuming cpu_sr_t in the first add
rather than the second.  But otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]