[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/9] target-sh4: optimize negc using add2 and
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/9] target-sh4: optimize negc using add2 and sub2 |
Date: |
Tue, 24 Dec 2013 06:25:32 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
> + TCGv t0 = tcg_const_i32(0);
> + tcg_gen_add2_i32(REG(B11_8), cpu_sr_t,
> + REG(B7_4), t0, cpu_sr_t, t0);
> + tcg_gen_sub2_i32(REG(B11_8), cpu_sr_t,
> + t0, t0, REG(B11_8), cpu_sr_t);
While this formulation is correct, I wonder why you strayed from the two
subtracts model of subc, since negc is similarly described in the manual?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 0/9] target-sh4: optimizations and cleanups, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 6/9] target-sh4: split out Q and M from of SR and optimize div1, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 3/9] target-sh4: optimize addc using add2, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 2/9] target-sh4: Split out T from SR, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 5/9] target-sh4: optimize negc using add2 and sub2, Aurelien Jarno, 2013/12/22
- Re: [Qemu-devel] [PATCH v2 5/9] target-sh4: optimize negc using add2 and sub2,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 9/9] target-sh4: simplify tas instruction, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 8/9] target-sh4: remove dead code, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 4/9] target-sh4: optimize subc using sub2, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 7/9] target-sh4: factorize fmov implementation, Aurelien Jarno, 2013/12/22
- [Qemu-devel] [PATCH v2 1/9] target-sh4: use bit number for SR constants, Aurelien Jarno, 2013/12/22