qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw


From: Li Guang
Subject: Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw
Date: Thu, 26 Dec 2013 08:22:03 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.16) Gecko/20120421 Iceape/2.0.11

Peter Maydell wrote:
On 25 December 2013 07:21, liguang<address@hidden>  wrote:

This is where your patch should have had an explanation
for why you're making this change. What is the user outside
of hw/sd/ that needs this header that means we should
move it into include/ ?


I don't mean someone will include it outside of hw/sd, just in the
sense of "header files be better in a directory called include",

A10's SDHC(really an odd controller, without public datasheet) emulation
will use some of definitions in this file, and I think many other standard
SDHC will also be happy to include this file.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]