Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

[Peter Maydell]

On 26 December 2013 00:22, Li Guang <address@hidden> wrote:
> Peter Maydell wrote:
>> On 25 December 2013 07:21, liguang<address@hidden>  wrote:
>> This is where your patch should have had an explanation
>> for why you're making this change. What is the user outside
>> of hw/sd/ that needs this header that means we should
>> move it into include/ ?

> I don't mean someone will include it outside of hw/sd, just in the
> sense of "header files be better in a directory called include",

QEMU's policy is that header files used only by other C files within
that directory can live in that directory; include is for headers which
define functions to be used between modules.

> A10's SDHC(really an odd controller, without public datasheet) emulation
> will use some of definitions in this file, and I think many other standard
> SDHC will also be happy to include this file.

I think all of these will live inside hw/sd so there's no need to move
the header.

thanks
-- PMM