Re: [Qemu-devel] [PATCH 03/22] softfloat: Add 16 bit integer to float conversions

[Richard Henderson]

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> +/* We provide the int16 versions for symmetry of API with float-to-int */
> +INLINE float32 int16_to_float32(int_fast16_t v STATUS_PARAM)
> +{
> +    return int32_to_float32(v STATUS_VAR);
> +}

If you're going to have int16 versions, I don't think you should use
int_fast16_t, but rather int16_t so that we will properly truncate the incoming
value.  Otherwise there's not much point in having these, IMO.

And please add blank lines between the functions.


r~