[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to_zero |
Date: |
Tue, 31 Dec 2013 06:23:32 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 12/31/2013 05:35 AM, Peter Maydell wrote:
> From: Tom Musta <address@hidden>
>
> The float64_to_uint64_round_to_zero routine is incorrect.
>
> For example, the following test pattern:
>
> 46697351FF4AEC29 / 0x1.97351ff4aec29p+103
>
> currently produces 8000000000000000 instead of FFFFFFFFFFFFFFFF.
>
> This patch re-implements the routine to temporarily force the
> rounding mode and use the float64_to_uint64 routine.
>
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
>
> Signed-off-by: Tom Musta <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> fpu/softfloat.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Perhaps a duplicate with Tom's thread, but:
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 03/22] softfloat: Add 16 bit integer to float conversions, (continued)
[Qemu-devel] [PATCH 11/22] softfloat: Provide complete set of accessors for fp state, Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 15/22] target-arm: Prepare VFP_CONV_FIX helpers for A64 uses, Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to_zero, Peter Maydell, 2013/12/31
- Re: [Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to_zero,
Richard Henderson <=
[Qemu-devel] [PATCH 20/22] target-arm: A64: Add floating-point<->integer conversion instructions, Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 01/22] softfloat: Fix exception flag handling for float32_to_float16(), Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 02/22] softfloat: Add float to 16bit integer conversions., Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 22/22] target-arm: A64: Add support for FCVT between half, single and double, Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 16/22] target-arm: Rename A32 VFP conversion helpers, Peter Maydell, 2013/12/31
[Qemu-devel] [PATCH 10/22] softfloat: Fix float64_to_uint32_round_to_zero, Peter Maydell, 2013/12/31