Re: [Qemu-devel] [PATCH 10/22] softfloat: Fix float64_to_uint32_round_to_zero

[Richard Henderson]

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> From: Tom Musta <address@hidden>
> 
> The float64_to_uint32_round_to_zero routine is incorrect.
> 
> For example, the following test pattern:
> 
>     425F81378DC0CD1F / 0x1.f81378dc0cd1fp+38
> 
> will erroneously set the inexact flag.
> 
> This patch re-implements the routine to use the 
> float64_to_uint64_round_to_zero
> routine.  If saturation occurs we ignore any flags set by the
> conversion function and raise only Invalid.
> 
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
> 
> Signed-off-by: Tom Musta <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  fpu/softfloat.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~