[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_vscsi: Fix REPORT_LUNS handlin
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling |
|
Date: |
Thu, 02 Jan 2014 22:44:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 02/01/2014 19:14, Nathan Whitehorn ha scritto:
>> > He should do something like :
>> > resp_data[i] |= dev->id & 0x3f;
>> > here to avoid a dev->id > 63 from spilling into the address method field.
>> >
>> > Or probably should have a check for
>> > if dev->id > 3 then fail
> OK.
No need for that:
.max_channel = 7, /* logical unit addressing format */
.max_target = 63,
.max_lun = 31,
dev->id is thus bounded to 0..63.
Paolo
Re: [Qemu-devel] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling, Nathan Whitehorn, 2014/01/02