[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/25] target-arm: A64: Implement minimal set
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/25] target-arm: A64: Implement minimal set of EL0-visible sysregs |
Date: |
Sat, 4 Jan 2014 11:35:57 +0000 |
On 4 January 2014 02:34, Peter Crosthwaite <address@hidden> wrote:
> On Mon, Dec 23, 2013 at 8:49 AM, Peter Maydell <address@hidden> wrote:
>> +static const ARMCPRegInfo v8_cp_reginfo[] = {
>> + /* Minimal set of EL0-visible registers. This will need to be expanded
>> + * significantly for system emulation of AArch64 CPUs.
>> + */
>> + { .name = "NZCV", .state = ARM_CP_STATE_AA64,
>> + .opc0 = 3, .opc1 = 3, .opc2 = 0, .crn = 4, .crm = 2,
>> + .access = PL0_RW, .type = ARM_CP_NZCV },
>> + {. name = "FPCR", .state = ARM_CP_STATE_AA64,
>> + .opc0 = 3, .opc1 = 3, .opc2 = 0, .crn = 4, .crm = 4,
>> + .access = PL0_RW, .readfn = aa64_fpcr_read, .writefn = aa64_fpcr_write
>> },
>
> Indentation and spacing looks inconsistent.
So it does (I didn't even know it was syntactically valid to leave
a space after the '.' like that...) . Will fix.
Do you mind if I don't do a respin just for this?
thanks
-- PMM