On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote:
On 03.01.2014 11:37, Stefan Hajnoczi wrote:
Looks good. In order to merge this new block driver qemu-iotests
support for nfs is required. That way the block driver can be exercised
and checked for regressions (I guess you performed manual testing
during development).
Please see tests/qemu-iotests/common for examples of
NBD/SSH/Sheepdog/etc support.
The qemu-iotests test suite with raw, qcow2, and vmdk formats should
work on top of NFS. Assuming you have an NFS server already running
on localhost, something like the following should succeed:
cd tests/qemu-iotests
ln -s ../../x86_64-softmmu/qemu-system-x86_64 qemu
ln -s ../../qemu-img .
ln -s ../../qemu-io .
./check -nfs # raw format by default
./check -nfs -qcow2
./check -nfs -vmdk
Maybe -nfs should take the base NFS URI as an argument to allow more
flexible test configurations. It's up to you.
More info on qemu-iotests: http://qemu-project.org/Documentation/QemuIoTests
it seems that several tests are broken since they use commands like
rm -f or mv and have protocol generic. shall I fix this?
The _cleanup_test_img() function in common.rc has cases for
nbd/rbd/sheepdog. They don't invoke regular rm(1). Maybe you need to
add a case for NFS there too.
If you find something broken and can fix it that's great. If you cannot
fix it please report it so the nbd/rbd/sheepdog/ssh/etc maintainers can
investigate.