[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 19/24] target-arm: Ignore most exceptions from sc
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 19/24] target-arm: Ignore most exceptions from scalbn when doing fixpoint conversion |
Date: |
Mon, 6 Jan 2014 13:11:16 +0000 |
The VFP fixed point conversion helpers first call float_scalbn and
then convert the result to an integer. This scalbn operation may
set floating point exception flags for:
* overflow & inexact (if it overflows to infinity)
* input denormal squashed to zero
* output denormal squashed to zero
Of these, we only care about the input-denormal flag, since
the output of the whole scale-and-convert operation will be
an integer (so squashed-output-denormal and overflow don't
apply). Suppress the others by saving the pre-scalb exception
flags and only copying across a potential input-denormal flag.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
target-arm/helper.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 905abd3..00476a8 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -3986,18 +3986,27 @@ float##fsz HELPER(vfp_##name##to##p)(uint##isz##_t x,
uint32_t shift, \
return float##fsz##_scalbn(tmp, -(int)shift, fpst); \
}
+/* Notice that we want only input-denormal exception flags from the
+ * scalbn operation: the other possible flags (overflow+inexact if
+ * we overflow to infinity, output-denormal) aren't correct for the
+ * complete scale-and-convert operation.
+ */
#define VFP_CONV_FLOAT_FIX_ROUND(name, p, fsz, isz, itype, round) \
uint##isz##_t HELPER(vfp_to##name##p##round)(float##fsz x, \
uint32_t shift, \
void *fpstp) \
{ \
float_status *fpst = fpstp; \
+ int old_exc_flags = get_float_exception_flags(fpst); \
float##fsz tmp; \
if (float##fsz##_is_any_nan(x)) { \
float_raise(float_flag_invalid, fpst); \
return 0; \
} \
tmp = float##fsz##_scalbn(x, shift, fpst); \
+ old_exc_flags |= get_float_exception_flags(fpst) \
+ & float_flag_input_denormal; \
+ set_float_exception_flags(old_exc_flags, fpst); \
return float##fsz##_to_##itype##round(tmp, fpst); \
}
--
1.8.5
- [Qemu-devel] [PATCH v2 11/24] softfloat: Fix float64_to_uint32_round_to_zero, (continued)
- [Qemu-devel] [PATCH v2 11/24] softfloat: Fix float64_to_uint32_round_to_zero, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 18/24] target-arm: Rename A32 VFP conversion helpers, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 08/24] softfloat: Add float32_to_uint64(), Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 21/24] target-arm: A64: Add "Floating-point<->fixed-point" instructions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 19/24] target-arm: Ignore most exceptions from scalbn when doing fixpoint conversion,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 24/24] target-arm: A64: Add support for FCVT between half, single and double, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 14/24] softfloat: Add float16 <=> float64 conversion functions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 01/24] softfloat: Fix exception flag handling for float32_to_float16(), Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 02/24] softfloat: Add float to 16bit integer conversions., Peter Maydell, 2014/01/06