Re: [Qemu-devel] [PATCH 02/13] mxs: Add CONFIG_MXS to the arm-softmmu config

[Peter Maydell]

On 11 December 2013 13:56, Michel Pollet <address@hidden> wrote:
> Allows selective compilation of the MXS bits
>
> Signed-off-by: Michel Pollet <address@hidden>
> ---
>  default-configs/arm-softmmu.mak | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index e48f102..0d4cf95 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -71,6 +71,7 @@ CONFIG_BLIZZARD=y
>  CONFIG_ONENAND=y
>  CONFIG_TUSB6010=y
>  CONFIG_IMX=y
> +CONFIG_MXS=y
>  CONFIG_MAINSTONE=y
>  CONFIG_NSERIES=y
>  CONFIG_REALVIEW=y

In general we prefer to have a CONFIG_ switch for
each device (and then one for the board as well);
see for example the CONFIG_ALLWINNER_ switches just
added. So I think it would be better to add those
in the patches which add each device, rather than
just having this one here.

thanks
-- PMM