[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore |
Date: |
Mon, 06 Jan 2014 19:12:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131118 Thunderbird/17.0.11 |
On 01/05/14 08:27, Qiao Nuohan wrote:
> Function is used to write vmcore. If flag_flatten is specified, flatten format
> will be used. In flatten format, data is written block by block in vmcore.
> struct MakedumpfileDataHeader is used to indicate the offset and size of a
> data
> block.
>
> struct MakedumpfileDataHeader {
> int64_t offset;
> int64_t buf_size;
> };
>
> Signed-off-by: Qiao Nuohan <address@hidden>
> ---
> dump.c | 28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/dump.c b/dump.c
> index 89baeab..764db39 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -726,6 +726,34 @@ static int write_end_flat_header(int fd)
> return 0;
> }
>
> +static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf,
> + size_t size)
> +{
You might have wanted to const-qualify "*buf" here, but it certainly
doesn't warrant a respin.
Reviewed-by: Laszlo Ersek <address@hidden>
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, (continued)
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, Qiao Nuohan, 2014/01/13
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, Laszlo Ersek, 2014/01/13
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, Qiao Nuohan, 2014/01/13
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, Laszlo Ersek, 2014/01/13
- Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header, Qiao Nuohan, 2014/01/13
[Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy, Qiao Nuohan, 2014/01/05
[Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore, Qiao Nuohan, 2014/01/05
- Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore,
Laszlo Ersek <=
[Qemu-devel] [PATCH v6 11/11] Add 'query-dump-guest-memory-capability' command, Qiao Nuohan, 2014/01/05
[Qemu-devel] [PATCH v6 02/11] dump: Add API to write header of flatten format, Qiao Nuohan, 2014/01/05
[Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer, Qiao Nuohan, 2014/01/05
[Qemu-devel] [PATCH v6 10/11] dump: Make kdump-compressed format available for 'dump-guest-memory', Qiao Nuohan, 2014/01/05