qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is p


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.
Date: Wed, 08 Jan 2014 08:36:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Hani Benhabiles <address@hidden> writes:

> This would allow a user to be able to refer to the device when using commands
> like device_del.
>
> Signed-off-by: Hani Benhabiles <address@hidden>

No.

Device IDs belong to the user.  Any IDs the system picks automatically
can collide with the user's IDs.

Management applications assume that they can pick any ID they want.
Your patch can introduce ID collisions, and thus make existing
configurations fail.

If I remember correctly, a few legacy convenience options pick IDs for
historical reasons.  If you use them, you need to be aware of the IDs
they pick.  Management applications shouldn't use them.

We've discussed this a couple of times already, by the way.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]