qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC
Date: Wed, 8 Jan 2014 18:14:33 +1000



On Wed, Jan 8, 2014 at 5:27 PM, Li Guang <address@hidden> wrote:
> Beniamino Galvani wrote:
>>
>> On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote:
>>    
>>>
>>> Hi,
>>> please use prefix AwA10 for names instead of Aw,
>>> also PATCH 1/2.
>>>      
>>
>> Hi,
>>
>> I agree with you that there is an inconsistency in the naming of EMAC
>> and other A10 devices (timer, interrupt controller).
>>
>> But the EMAC core is used not only on the A10; since it can be found
>> on other SoC of the Allwinner family, shouldn't the name be generic so
>> that it can be reused more easily in the future by other SoC
>> implementations?
>>
>>    
>
>
> logic is:
> we emulated devices in A10, then when emulate other chips
> with same devices can freely use them.
>

That shouldn't dictate the naming scheme of the sharable IP however. In
this case, the name should reflect what it can be used for, not what it is used for.

Regards,
Peter

> Thanks!
>
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]