Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

[Alex Bennée]

address@hidden writes:

> On 7 January 2014 16:51, Peter Maydell <address@hidden> wrote:
<snip>
>
> Another option we could consider here is only pulling in the set of source
> files we compile plus the headers they require, not the whole library. That's
<snip>
>
> for about 6600 lines total. That's a significant reduction in the amount of
> code we're carrying around; the tradeoff is that if/when we have to update
> to a new libvixl it's not quite such a simple drop-in replacement as it might
> otherwise be, since you'd need to do the trimming down of files again.
> On balance I think only taking the files we use is probably the best thing.

It also raises the question of our policy of embedding 3rd party code.
Are there any other examples other than softfloat? AFAIK thinks like the
roms use git sub-modules rather than importing things.

There is another philosophical question of why have two decoders when we
already have one (which doesn't generate assembler atm) but I suspect
have a working dis-assembler is better than none.


Cheers,

--
Alex Bennée
QEMU/KVM Hacker for Linaro