Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

[Gabriel L. Somlo]

On Thu, Jan 09, 2014 at 11:33:59PM +0200, Michael S. Tsirkin wrote:
> Except XP doesn't support ConcatenateResTemplate so need to write
> it differently.

I tried this:

    Device(HPET) {
...
        Field(HPTM, DWordAcc, Lock, Preserve) {
            VEND, 32,
            PRD, 32,
            UNUS, 32,
            GCNF, 32,
        }
...
        Name(CRS1, ResourceTemplate() {
            Memory32Fixed(ReadOnly,
                0xFED00000,         // Address Base
                0x00000400,         // Address Length
                )
        })
        Name(CRS2, ResourceTemplate() {
            IRQNoFlags() {2, 8}
            Memory32Fixed(ReadOnly,
                0xFED00000,         // Address Base
                0x00000400,         // Address Length
                )
        })
        Method(_CRS, 0) {
            Store(GCNF, Local0)
            If (LEqual(LAnd(Local0, 3), 3)) { // Legacy replacement route
                Return (CRS2)
            } else {
                Return (CRS1)
            }
        }
    }

and got the same results.

Besides, does it *really* matter? XP always takes the "else" branch,
so it should never attempt to execute "ConcatenateResTemplate()" anyway.

--Gabriel