Re: [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters()

[Max Reitz]

On 05.01.2014 20:43, Wenchao Xia wrote:
> The return value can help caller check whether error happens,
> and it does not need to have *errp since the return value already tips
> what happend.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>   block/qcow2-refcount.c |    8 +++++---
>   block/qcow2.h          |    6 +++---
>   2 files changed, 8 insertions(+), 6 deletions(-)

I'm not sure if we actually need this since it's never really bad to 
have an error occur in qcow2_free_clusters(); at least, there's nothing 
the caller can do about that and it never blocks any subsequent 
operation, so most callers just don't care. But it won't hurt, either, so:

Reviewed-by: Max Reitz <address@hidden>