Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

[Michael S. Tsirkin]

On Mon, Jan 13, 2014 at 03:56:49PM +0100, Paolo Bonzini wrote:
> Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto:
> > 
> >         if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) {
> >                 printk(KERN_ERR "virtio_pci: expected ABI version %d,
> > got %d\n",
> >                        VIRTIO_PCI_ABI_VERSION, pci_dev->revision);
> >                 return -ENODEV;
> >         }
> > 
> > so it seems better to be consistent.
> > in any case, we must check subsystem ids, the spec is very
> > explicit on this point.
> 
> This is not a virtio device.
> 
> Paolo

oh
I didn't realize that - thought it's virtio serial we are talking about.
In that case I agree with Gerd.