Re: [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x

[Stefan Hajnoczi]

On Thu, Oct 24, 2013 at 08:46:02PM -0400, Mohamad Gebai wrote:
> Version 5
> 
> * Use pkg-config for lttng-ust and urcu-bp libraries in configure (hard-coded
>   libraries as a fallback)
> * s/Qemu/QEMU in docs/tracing.txt
> * Better dependencies for ust-generated files in trace/Makefile.obj
> 
> Mohamad Gebai (5):
>   Fix configure script for LTTng 2.x
>   Modified the tracetool framework for LTTng 2.x
>   Adapt Makefiles to the new LTTng ust interface
>   Update documentation for LTTng ust tracing
>   Add ust generated files to .gitignore
> 
>  .gitignore                               |  2 +
>  Makefile                                 |  5 ++
>  configure                                | 20 ++++++--
>  docs/tracing.txt                         | 36 ++++++++++++++
>  scripts/tracetool/backend/events.py      | 44 +++++++++++++++++
>  scripts/tracetool/backend/ust.py         | 82 
> +++++++-------------------------
>  scripts/tracetool/format/ust_events_c.py | 30 ++++++++++++
>  scripts/tracetool/format/ust_events_h.py | 57 ++++++++++++++++++++++
>  trace/Makefile.objs                      | 25 ++++++++++
>  9 files changed, 230 insertions(+), 71 deletions(-)
>  create mode 100644 scripts/tracetool/format/ust_events_c.py
>  create mode 100644 scripts/tracetool/format/ust_events_h.py

Sorry for taking so long to review this.  I have tested it successfully
on Fedora 20.  Just a few comments on the patches but looking good.