Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

[Paolo Bonzini]

Il 14/01/2014 15:47, Richard Henderson ha scritto:
>>>> +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
>>> >>
>>> >> I really really don't like random numbers that make for non-repeatable 
>>> >> builds.
>>> >>  It's a quality-assurance nightmare.
>> > 
>> > Can you elaborate this, please?
> Build systems like we use at Red Hat want to be able to produce bit-for-bit
> identical binaries when given the exact same input.  Using random numbers
> during the build process prevents that.

I totally agree, but AIUI people wanted the symbol to be something that
you couldn't know in advance (e.g. when compiling an out-of-tree
module).  For some definition of "couldn't" and "in advance".

I think we should simply drop the requirement to check a symbol in the
modules.

Paolo

>>> >> and perhaps a file containing that hash created by scripts/make-release.
>> > 
>> > What if the source code is not in a git tree, for example a tarball?
> You just quoted my answer to that.