[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable funct
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW |
Date: |
Tue, 14 Jan 2014 19:18:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Weil <address@hidden> wrote:
> Am 14.01.2014 18:26, schrieb Michael Tokarev:
>> 14.01.2014 10:00, Stefan Weil wrote:
>>> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
>>> unavailable for MinGW. As the function is unused for MinGW, it can simply
>>> be excluded from compilation.
>> I applied it to -trivial. But maybe it's better to just move whole
>> thing to kvm-all.c where
>> it is actually used?
>>
>> Thanks,
>>
>> /mjt
>
> That's a good suggestion.
Let it as your change. Functions on ram_addr.h should be opaque, and
nothing else should access the bitmap.
>
> Juan, a comment in include/exec/ram_addr.h says that those functions
> will be removed soon. Would you suggest moving them to kvm-all.c now, or
> would you prefer the conditional compilation for MinGW which I
> introduced with my patch?
The "soon" was introduced when Memory API was included, and we are still
waiting on TCG.
Later, Juan.