[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gdbstub: allow byte swapping for reading/writin
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] gdbstub: allow byte swapping for reading/writing registers |
Date: |
Wed, 15 Jan 2014 18:40:42 +0100 |
On 15.01.2014, at 18:29, Ulrich Weigand <address@hidden> wrote:
> Alexander Graf <address@hidden> wrote on 14.01.2014 23:40:20:
>> On 14.01.2014, at 23:06, Thomas Falcon <address@hidden>
> wrote:
>>
>>> This patch allows registers to be properly read from and written to
>>> when using the gdbstub to debug a ppc guest running in little
>>> endian mode. It accomplishes this goal by byte swapping the values of
>>> any registers only if the MSR:LE value is set and if the host machine
>>> is big endian.
>>>
>>> Signed-off-by: Thomas Falcon<address@hidden>
>>
>> Uli, I thought ppc64le gdb wasn't finalized yet? What does the
>> gdbstub layout look like? Are all fields the same as ppc64(be) but
>> simply byte swapped - including FPR ones?
>
> Hi Alex, yes, the layout of the gdb protocol packets should be the
> same as on BE, except that all registers are byte-swapped. This
> includes FPRs and VPRs.
Phew - I don't think we have byte swapping primitives above 64bit :).
But good, then let's abstract this whole swappiness one level higher as
indicated in my previous email. That way we're guaranteed to not miss any
fields by accident.
Alex