[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs |
Date: |
Thu, 16 Jan 2014 20:40:04 +0800 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Thu, 01/16 11:04, Peter Maydell wrote:
> On 15 January 2014 08:48, Fam Zheng <address@hidden> wrote:.objs.
> > Similarly,
> >
> > foo.o-cflags := $(FOO_CFLAGS)
> >
> > is also supported.
>
> I noticed that we already support per-object cflags via:
>
> $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBUILD_Y8950=0
>
> (this example from audio/Makefile.objs). Is your new
> method better in some way? Are we going to convert
> users of the old-style method?
>
I added this new method as it's cleaner to use, especially when defining
multiple-object module (implemented in this series):
foo.mo-objs := bar.o biz.o qux.o
, compared to
$(obj)/foo.mo-objs := $(obj)/bar.o $(obj)/biz.o $(obj)/qux.o
or slightly better
$(obj)/foo.mo-objs := $(addprefix $(obj), bar.o, biz.o, qux.o)
I've already converted block/curl.o's cflags to this, later in this series. So
yes I think this is a better syntax.
Thanks,
Fam
- [Qemu-devel] [PATCH v16 0/9] Shared library module support, Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 4/9] darwin: do not use -mdynamic-no-pic, Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 8/9] .gitignore: ignore module related files (dll, so, mo), Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 9/9] block: convert block drivers linked with libs to modules, Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 7/9] Makefile: install modules with "make install", Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 3/9] block: use per-object cflags and libs, Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO, Fam Zheng, 2014/01/15
- [Qemu-devel] [PATCH v16 6/9] module: implement module loading, Fam Zheng, 2014/01/15