[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate '
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id' |
|
Date: |
Thu, 16 Jan 2014 09:50:44 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/16/2014 09:34 AM, Igor Mammedov wrote:
s/ingnore/ignore/ in subject
> object_property_add_child() may fail if 'id' matches
> an already existing object. Which meansi an incorrect
s/meansi/means/
> command line.
> So instead of silently ignoring error, report it and
> terminate QEMU.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> vl.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
Fix those, and you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization, Igor Mammedov, 2014/01/16
- [Qemu-devel] [PATCH v1 1/4] object_add: consolidate error handling, Igor Mammedov, 2014/01/16
- [Qemu-devel] [PATCH v1 3/4] add optional 2nd stage initialization to -object/object-add commands, Igor Mammedov, 2014/01/16
- [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id', Igor Mammedov, 2014/01/16
- Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id',
Eric Blake <=
- [Qemu-devel] [PATCH v1 4/4] virtio_rng: replace custom backend API with UserCreatable.complete() callback, Igor Mammedov, 2014/01/16
- Re: [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization, Stefan Hajnoczi, 2014/01/17
- Re: [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization, Luiz Capitulino, 2014/01/22