[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() funct
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function |
Date: |
Fri, 17 Jan 2014 11:29:39 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 16, 2014 at 11:29:34AM +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 14, 2014 at 11:59:46AM +0100, Vincenzo Maffione wrote:
> > This function was used to set the using_vnet_hdr field into the
> > TAPState struct. However, it is always called immediately before
> > (see virtio-net.c) or immediately after (see vmxnet3.c) the function
> > tap_set_vnet_hdr_len(). It's therefore possible to set the
> > using_vnet_hdr field directly in tap_set_vnet_hdr_len() and remove
> > tap_using_vnet_hdr(), making the code simpler.
> >
> > Signed-off-by: Vincenzo Maffione <address@hidden>
>
>
> virtio net only calls tap_set_vnet_hdr_len if tap_has_vnet_hdr_len
> returns true.
> I think this patch will break old linux hosts which don't support
> modifying vnet_hdr_len.
This is a good point. Let's leave the API alone then.
Stefan
- [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 1/6] net: change vnet-hdr TAP prototypes, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 4/6] net: TAP uses NetClientInfo offloading callbacks, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 6/6] net: add offloadings support to netmap backend, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 3/6] net: extend NetClientInfo for offloading manipulations, Vincenzo Maffione, 2014/01/14
- [Qemu-devel] [PATCH v2 5/6] net: virtio-net and vmxnet3 use offloading API, Vincenzo Maffione, 2014/01/14
- Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support, Barak Wasserstrom, 2014/01/15
- Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support, Stefan Hajnoczi, 2014/01/16