[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block: resize backing file image during off
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary |
Date: |
Fri, 17 Jan 2014 15:23:00 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 13, 2014 at 03:18:45PM -0500, Jeff Cody wrote:
> @@ -1904,7 +1904,19 @@ int bdrv_commit(BlockDriverState *bs)
> }
> }
>
> - total_sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
> + length = bdrv_getlength(bs);
> +
> + /* If our top snapshot is larger than the backing file image,
> + * grow the backing file image if possible. If not possible,
> + * we must return an error */
> + if (length > bdrv_getlength(bs->backing_hd)) {
> + ret = bdrv_truncate(bs->backing_hd, length);
bdrv_getlength() is allowed to return -errno. It's unlikely here but we
should at least check bdrv_getlength(bs), probably also
bdrv_getlength(bs->backing_hd).
- [Qemu-devel] [PATCH 0/2] block: commits of snapshots larger than backing files, Jeff Cody, 2014/01/13
- [Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary, Jeff Cody, 2014/01/13
- Re: [Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/2] block: resize backing image during active layer commit, if needed, Jeff Cody, 2014/01/13
- Re: [Qemu-devel] [PATCH 0/2] block: commits of snapshots larger than backing files, Stefan Hajnoczi, 2014/01/17