[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error m
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message |
Date: |
Mon, 20 Jan 2014 12:55:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Alon Levy <address@hidden> writes:
> Signed-off-by: Alon Levy <address@hidden>
> ---
> hw/display/qxl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index e4f172e..f6af470 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1367,7 +1367,8 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl,
> int loadvm,
> size = abs(requested_stride) * requested_height;
> if (size > qxl->vgamem_size) {
> qxl_set_guest_bug(qxl, "%s: requested primary larger then
> framebuffer"
> - " size", __func__);
> + " size %d > %d", __func__, size,
> + qxl->vgamem_size);
> return;
> }
Shouldn't you use %u or %PRIu32 to print uint32_t qxl->vgamem_size?
Hmm, we're comparing int size to uint32_t vgamem_size, not nice. Should
size be unsigned?
Since you touch the message anyway, you could fix "larger then" to
"larger than".