qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v19 02/25] qapi: output def_value_str when query comma


From: Eric Blake
Subject: Re: [Qemu-devel] [v19 02/25] qapi: output def_value_str when query command line options
Date: Mon, 20 Jan 2014 08:53:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/20/2014 07:19 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when query
> command line options.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -3891,12 +3891,16 @@
>  #
>  # @help: #optional human readable text string, not suitable for parsing.
>  #
> -# Since 1.5
> +# @default: #optional string representation of the default used
> +#           if the option is omitted.
> +#
> +# Since 1.6

Not quite right.  The overall type was still since 1.5, and only the new
member is since 2.0 (not 1.6).  It should look more like:

# @default: #optional string representation of the default used if
#           the option is omitted (since 2.0)
#
# Since 1.5

But I like the idea.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]