Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

[Fam Zheng]

On Thu, 12/12 16:33, Benoît Canet wrote:
> v5:
>     block empty node names [Kevin]
>     factorize setting of node-name option [Kevin]
>     NULL terminate node_name on removal [Kevin]
>     make query-named-block-nodes return BlockDeviceInfo structure [Eric]
>     Change some doc in query-named-block-nodes [Eric]
>     Document the choice of the QMP API for node name [Eric]
>     Use the same authorization as snapshot on block resize [Kevin]
>     Rebase the series [Kevin]

Looks mostly good to me. But the external snapshot permission protection
interface looks a bit obsecuer to me. Let's wait for other reviewers' comments.

Thanks,
Fam

> 
> Benoît Canet (7):
>   block: Add bs->node_name to hold the name of a bs node of the bs
>     graph.
>   block: Allow the user to define "node-name" option.
>   qmp: Add a command to list the named BlockDriverState nodes.
>   qmp: Allow to change password on named block driver states.
>   block: Create authorizations mechanism for external snapshot and
>     resize.
>   qmp: Allow block_resize to manipulate bs graph nodes.
>   qmp: Allow to take external snapshots on bs graphs node.
> 
>  block.c                   | 210 
> +++++++++++++++++++++++++++++++++++++++++-----
>  block/blkverify.c         |   2 +-
>  block/qapi.c              | 109 ++++++++++++------------
>  blockdev.c                |  93 ++++++++++++++++----
>  hmp.c                     |   8 +-
>  include/block/block.h     |  23 +++--
>  include/block/block_int.h |  21 ++++-
>  include/block/qapi.h      |   1 +
>  qapi-schema.json          |  48 +++++++++--
>  qmp-commands.hx           |  78 ++++++++++++++++-
>  10 files changed, 471 insertions(+), 122 deletions(-)
> 
> -- 
> 1.8.3.2
>