[Qemu-devel] [PATCH] drive-mirror: fix memory leak

[Chentao (Boby)]

In the function mirror_iteration() -> qemu_iovec_init(), it alloc memory for op->qiov.iov, when the write request call back,

 

but in the function mirror_iteration_done(), it only free the op, not free the op->qiov.iov, so this cause memory leak.

 

Signed-off-by: Zhang Min <address@hidden>

---

block/mirror.c |    1 +

1 files changed, 1 insertions(+), 0 deletions(-)

 

diff --git a/block/mirror.c b/block/mirror.c index 2932bab..9840840 100644

--- a/block/mirror.c

+++ b/block/mirror.c

@@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)

         bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);

     }

 

+    g_free(op->qiov.iov);

     g_slice_free(MirrorOp, op);

     qemu_coroutine_enter(s->common.co, NULL);  }

--