[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on |
|
Date: |
Tue, 21 Jan 2014 09:17:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/21/2014 09:14 AM, Jeff Cody wrote:
> Important note: this patch should only be applied after patch
> "block: do not allow read-only=on and snapshot=on to be used together"
>
> Now that 'read-only=on' and 'snapshot=on' are not allowed together,
> forcing open_flags to have BDRV_O_RDWR set is redundant code, and can be
> removed. This is because unless read-only=on is specified, the image
> will always be opened with BDRV_O_RDWR set.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block.c | 7 -------
> 1 file changed, 7 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature