[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: catch zero-length strings
|
From: |
Kevin O'Connor |
|
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: catch zero-length strings |
|
Date: |
Tue, 21 Jan 2014 14:52:42 -0500 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 21, 2014 at 01:24:02PM +0100, Gerd Hoffmann wrote:
> qemu may pass us zero-length strings for smbios fields, when starting
> qemu this way ...
>
> qemu -smbios type=1,version=,serial=test
>
> ... for example.
>
> Today we don't specifically handle them and simply append them to the
> string list. Therefore we get two string-terminating zeros in a row.
> Result is that we by accident create a end-of-entry marker in the middle
> of the entry.
>
> Fix this by handling zero-length strings like non-present strings.
Looks okay to me.
I wish we could get all of the smbios stuff moved to qemu.
-Kevin