[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] drive-mirror:fix memory leak
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] drive-mirror:fix memory leak |
Date: |
Wed, 22 Jan 2014 16:27:03 +0800 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Wed, 01/22 15:56, Zhang Min wrote:
> In the function mirror_iteration() -> qemu_iovec_init(),
> it allocates memory for op->qiov.iov, when the write request calls back,
> but in the function mirror_iteration_done(), it only frees the op,
> not free the op->qiov.iov, so this causes memory leak.
>
> Signed-off-by: Zhang Min <address@hidden>
> ---
> block/mirror.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 2932bab..9840840 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)
> bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
> }
>
> + g_free(op->qiov.iov);
> g_slice_free(MirrorOp, op);
> qemu_coroutine_enter(s->common.co, NULL);
> }
> --
> 1.7.3.1.msysgit.0
>
Reviewed-by: Fam Zheng <address@hidden>
In the future please keep maintainers Cc'ed, as noted in the wiki page, so your
patch can get better chance of being noticed.
http://wiki.qemu.org/Contribute/SubmitAPatch
> Send patches to the mailing list and CC the relevant maintainer -- look in
> the MAINTAINERS file to find out who that is. Also try using
> scripts/getmaintainer.pl from the repository for learning the most common
> committers for the files you touched.