[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support |
Date: |
Wed, 22 Jan 2014 17:55:57 +0000 |
On 22 January 2014 16:20, Gerd Hoffmann <address@hidden> wrote:
> cocoa ui code has been updated, but is totally untested (not even
> compiled). Would be great if someone with macos hardware can give
> it a spin, and send fixup patches if needed.
OBJC ui/cocoa.o
/Users/pm215/src/qemu/ui/cocoa.m:673:17: error: use of undeclared
identifier 'button'; did you mean 'buttons'?
button |= ([event deltaY] < 0) ?
^~~~~~
buttons
/Users/pm215/src/qemu/ui/cocoa.m:496:9: note: 'buttons' declared here
int buttons = 0;
^
/Users/pm215/src/qemu/ui/cocoa.m:693:39: error: use of undeclared
identifier 'con'; did you mean 'cos'?
qemu_input_update_buttons(con, bmap, last_buttons, buttons);
^~~
cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
^
/Users/pm215/src/qemu/ui/cocoa.m:693:39: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
[-Wincompatible-pointer-types]
qemu_input_update_buttons(con, bmap, last_buttons, buttons);
^~~
/Users/pm215/src/qemu/include/ui/input.h:41:45: note: passing argument
to parameter 'src' here
void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
^
/Users/pm215/src/qemu/ui/cocoa.m:699:20: error: use of undeclared
identifier 'isMouseGrabed'; did you mean 'isMouseGrabbed'?
} else if (isMouseGrabed) {
^~~~~~~~~~~~~
isMouseGrabbed
/Users/pm215/src/qemu/ui/cocoa.m:256:10: note: 'isMouseGrabbed' declared here
BOOL isMouseGrabbed;
^
/Users/pm215/src/qemu/ui/cocoa.m:700:34: error: use of undeclared
identifier 'con'; did you mean 'cos'?
qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]);
^~~
cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
^
/Users/pm215/src/qemu/ui/cocoa.m:700:34: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
[-Wincompatible-pointer-types]
qemu_input_queue_rel(con, INPUT_AXIS_X, (int)[event deltaX]);
^~~
/Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument
to parameter 'src' here
void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value);
^
/Users/pm215/src/qemu/ui/cocoa.m:701:34: error: use of undeclared
identifier 'con'; did you mean 'cos'?
qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]);
^~~
cos
/usr/include/math.h:332:15: note: 'cos' declared here
extern double cos(double);
^
/Users/pm215/src/qemu/ui/cocoa.m:701:34: warning: incompatible pointer
types passing 'double (double)' to parameter of type 'QemuConsole *'
(aka 'struct QemuConsole *')
[-Wincompatible-pointer-types]
qemu_input_queue_rel(con, INPUT_AXIS_Y, (int)[event deltaY]);
^~~
/Users/pm215/src/qemu/include/ui/input.h:48:40: note: passing argument
to parameter 'src' here
void qemu_input_queue_rel(QemuConsole *src, InputAxis axis, int value);
^
3 warnings and 5 errors generated.
make: *** [ui/cocoa.o] Error 1
thanks
-- PMM
- [Qemu-devel] [PATCH v2 31/42] input: trace events, (continued)
- [Qemu-devel] [PATCH v2 31/42] input: trace events, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 42/42] input: remove index_from_keycode (no users), Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 39/42] sdl2: codestyle fixups, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 32/42] input-legacy: remove kbd_put_keycode, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 40/42] input: move qmp_query_mice to new core, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 41/42] input: move do_mouse_set to new core, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 37/42] input: add input_mouse_mode tracepoint, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 38/42] sdl2: simplify keymap handling, Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 30/42] input: mouse: switch cocoa ui to new core [untested], Gerd Hoffmann, 2014/01/22
- [Qemu-devel] [PATCH v2 36/42] input: move mouse mode notifier to new core, Gerd Hoffmann, 2014/01/22
- Re: [Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support,
Peter Maydell <=