Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

[Gonglei (Arei)]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Tuesday, January 21, 2014 9:46 PM
> To: Gonglei (Arei); address@hidden; address@hidden; Peter
> Maydell; address@hidden; address@hidden
> Cc: chenliang (T); Luonengjun; Huangweidong (Hardware)
> Subject: Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf
> wrong
> 
> On 01/21/2014 05:11 AM, Gonglei (Arei) wrote:
> > Hi,
> 
> This greeting...
> 
> >
> > This is an update of my patch.
> > Modifications in v2:
> 
> ...and this mention of what you changed in v2,...
> 
> > * Removing excess check for g_free
> > * The structure of XBZRLE is divided into two halves.One is for
> > * src side, another is for dest side.
> >
> > Signed-off-by: chenliang <address@hidden>
> > ---
> 
> ...belong here, after the --- marker.  Basically, patch emails should
> have two portions: the long-lived portion before the --- that will be
> stashed into git and which will always be relevant to someone reading
> the patch a year from now, and the transient portion after the --- that
> is helpful to reviewers that have context about why you are on v2, but
> which makes no difference in git (a year from now, we won't care if it
> took 1 version or 20 versions to get to the final patch, because git
> will only have the final version).
> 
> If you need help writing a good commit message, browsing 'git log' will
> give you some ideas.  See also http://wiki.qemu.org/Contribute/SubmitAPatch
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

Thank you so much, Eric. I will learn the guidelines and then send another 
patch.

Best regards,
-Gonglei