Re: [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema

[Amos Kong]

On Thu, Jan 23, 2014 at 11:53:24AM +0100, Markus Armbruster wrote:
> Amos Kong <address@hidden> writes:
> 
> > After cleaning up the comments of qapi-schema.json file, we get
> > an range of raw expressions, they are also converted to ordered
> > dictionaries.
> >
> > This patch just addes a member to QAPISchema to store the raw
> > expressions.
> >
> > Actually this patch was split from QMP introspection patchset,
> > it's no longer needed in that patchset. I would like to post
> > this patch singly, we can apply it if it's useful.
> 
> It'll be useful when it has a user, or if it eases maintenance.  Neither
> is obvious to me at a quick, superficial glance.

The patch didn't change original parse logic, it just repeatedly
save each single clear schema to a list in existed loop. I think
it's easy to maintain.

In the introspection patchset, I want to pass raw json expressions
to C code by a head file, then convert the json expressions to
qobject, then ...

At the end, I generated a expression with more metadata when visit
Ordered Dictionaries. So raw expressions were not used.
 
> Happy to hear a more verbose explanation of what raw expressions might
> be good for.

-- 
                        Amos.