[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction ini
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init |
|
Date: |
Thu, 23 Jan 2014 14:36:53 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Marcel Apfelbaum <address@hidden> writes:
> Scenario:
> - There is a non multifunction pci device A on 00:0X.0.
> - Hot-plug another multifunction pci device B at 00:0X.1.
> - The operation will fail of course.
> - Try to hot-plug the B device 2-3 more times, qemu will crash.
>
> Reason: The error flow leaves the B's address space into global address spaces
> list, but the device object is freed. Fixed that.
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
Looks good to me, but I'm not a PCI expert.