Re: [Qemu-devel] [PATCH 11/13 v7] dump: add API to write dump pages

[Laszlo Ersek]

On 01/17/14 08:46, qiaonuohan wrote:
> functions are used to write page to vmcore. vmcore is written page by page.
> page desc is used to store the information of a page, including a page's size,
> offset, compression format, etc.
> 
> Signed-off-by: Qiao Nuohan <address@hidden>
> ---
>  dump.c                |  229 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  include/sysemu/dump.h |    7 ++
>  2 files changed, 236 insertions(+), 0 deletions(-)

You seem to have addressed everything I said for v6 09/11, except the
QEMU_PACKED for PageDesc, but that's fine.

(BTW I've just noticed that "PageDesc" is already used in
"translate-all.c". No conflict here, but you might want to rename your
struct, if you spin a v8 anyway.)

All in all, great job!

Reviewed-by: Laszlo Ersek <address@hidden>