Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

[Andreas Färber]

Am 23.01.2014 17:00, schrieb Peter Maydell:
> On 23 January 2014 15:45, Andreas Färber <address@hidden> wrote:
>> I have also now sent out a patch covering Macs and e500. So the answer
>> is, I will accept a patch that has a reasonably small blacklist. The
>> time you're arguing about this on IRC and here you could've spent
>> actually helping investigate and fixing this... Even if I queued it and
>> sent a pull, it would take days or weeks to go in, so I really don't see
>> why I should rush this series into my tree.
> 
> That's cool. I was only arguing because I was under the mistaken
> impression you didn't want to take this patch at all until
> everything was fixed.

Well, maybe "everything" is the misunderstanding here?

The following 3 patches address all my requests, ...

http://patchwork.ozlabs.org/patch/313620/
http://patchwork.ozlabs.org/patch/313642/
http://patchwork.ozlabs.org/patch/313659/

... and the first two would've been really easy to contribute for anyone
who cared about a proper white- or blacklist: introducing a new define
and taking away devices as long as everything still passes make check.
More cleanup would be possible (i8257) if we took away audio, too (sb16
etc.).
ppc40x was more involved, but still less than an hour to figure out.

Now waiting on Alex to review and send a pull or to ack for me to queue.

Having had to write these fixes myself now, maybe one of you two can
contribute the real QOM test of recursively walking properties via
qom-list and qom-get? :)

> I'm working on a patch which improves tests/Makefile so it
> autogenerates the list of sysemu-supporting targets and
> adds qom-test to the test list for all of them, so we don't
> even have to update the makefile when we add new architectures.

Appreciate it,

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg