Re: [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

[Peter Maydell]

On 23 January 2014 20:08, C Fontana <address@hidden> wrote:
>> +    if (extended_result) {
>> +        tcg_temp_free(tcg_src_hi);
>
>
>
> should this be tcg_temp_free_i64 ?

Yes, though it doesn't actually make a difference here
since we know we're building a 64 bit target QEMU.

>> +    return;
>
>
> no harm but maybe remove return?

Agreed, and again on the second one.

thanks
-- PMM